bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-6.5 released (stable)


From: Jim Meyering
Subject: Re: coreutils-6.5 released (stable)
Date: Mon, 20 Nov 2006 13:59:56 +0100

Andreas Schwab <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> If you haven't heard about the GNU coreutils, the FAQ is a good
>> place to start: <http://www.gnu.org/software/coreutils/faq/>.
>>
>> This is a stable release.

Well, I'm confident that the coreutils part was stable.
It'd sure be nice to keep gnulib's instability from affecting
"stable" coreutils releases.

> NLS configuration is broken.

Thanks for the quick patch.  I've applied it in gnulib.
For those wondering, this bug caused coreutils' configure-time
test for gettext to fail like this on our favorite systems:

    checking for GNU gettext in libc... no
    checking for iconv... (cached) yes
    checking for GNU gettext in libintl... no
    checking whether to use NLS... no

In config.log, there were new compile errors:

    configure:51552: checking for GNU gettext in libc
    configure:51582: gcc -std=gnu99 -o conftest -g   -Wl,--as-needed conftest.c 
 >&5
    conftest.c:437: error: expected identifier or '(' before '[' token

Since the offending file comes from gettext via gnulib,
I've cc'd those lists.

Bruno, gettext's gettext-runtime/m4/gettext.m4 (version 1.39)
needs a similar change in three places.

2006-11-20  Andreas Schwab  <address@hidden>  (tiny change)

        Avoid syntax error in test program.
        * m4/gettext.m4 (AM_GNU_GETTEXT): When inside a [...] context,
        quote with "[...]", not "[[...]]".

Index: m4/gettext.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/gettext.m4,v
retrieving revision 1.35
diff -u -p -r1.35 gettext.m4
--- m4/gettext.m4       27 Oct 2006 14:06:54 -0000      1.35
+++ m4/gettext.m4       20 Nov 2006 10:55:44 -0000
@@ -137,12 +137,12 @@ AC_DEFUN([AM_GNU_GETTEXT],
         dnl to fall back to GNU NLS library.

         if test $gt_api_version -ge 3; then
-          gt_revision_test_code='[[
+          gt_revision_test_code='[
 #ifndef __GNU_GETTEXT_SUPPORTED_REVISION
 #define __GNU_GETTEXT_SUPPORTED_REVISION(major) ((major) == 0 ? 0 : -1)
 #endif
 typedef int array [2 * (__GNU_GETTEXT_SUPPORTED_REVISION(0) >= 1) - 1];
-]]'
+]'
         else
           gt_revision_test_code=
         fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]