bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gzip 1.3.6 broken on Tandem NSK/OSS


From: Matthew Woehlke
Subject: Re: gzip 1.3.6 broken on Tandem NSK/OSS
Date: Wed, 06 Dec 2006 09:57:49 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0

Paul Eggert wrote:
Matthew Woehlke <address@hidden> writes:
gzip 1.3.6 does not build on Tandem NSK/OSS because it uses fchdir,
which does not exist on NSK/OSS. This was added in gzip 1.3.5. Is
there a replacement for this function (e.g. in gnulib)? Can its use be
removed/conditionalized?

I looked into this some more, and decided that since all gzip uses
is fdopendir, it's overkill for gzip to bring in all of the openat
module.  Perhaps we should split out fdopendir into a separate
module?  But that'd be a tricky business, and right now I'm trying
to get a stable gzip out the door.  Besides, gzip should really
be using openat, as that is safer than the current approach.

For now I installed this patch to gzip.  This way, gzip doesn't use
openat.  It does use fdopendir if the underlying system has it,
though.  This lets gzip be safer on modern platforms (glibc 2.4,
Solaris 10) but less safe on older ones.  Since it's been less-safe
for a decade without anyone complaining, I guess that's good enough.

[patch snipped]

That seems like a good solution, thanks! FYI I'm not giving up on an fchdir module yet (coreutils is eventually going to need it, after all, but I will be very happy if I have a working gzip before that :-)), it's just not very high on my priority list and I'm in the middle of a bunch stuff ATM.

Honestly, I'm a little confused/amused with this whole situation... :-) I'm used to using gzip as a stream compressor that /occasionally/ opens a file, unlinks it, and puts back a different file. I can't say I've ever done anything more sophisticated than that with gzip. Mostly I need tar's 'j' flag to work. :-)

--
Matthew
Not to be used as a flotation device.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]