bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: canonicalize: remove redundant macro definitions


From: Jim Meyering
Subject: Re: canonicalize: remove redundant macro definitions
Date: Wed, 03 Jan 2007 10:27:52 +0100

Bruno Haible <address@hidden> wrote:
> Hi Jim,
>
> Now that gnulib-tool defines GNULIB_CANONICALIZE when the canonicalize module
> is in use, the PROVIDE_CANONICALIZE_FILENAME_MODE macro is redundant. Here is
> a proposed patch:
>
> 2007-01-01  Bruno Haible  <address@hidden>
>
>       * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME): Remove
>       PROVIDE_CANONICALIZE_FILENAME_MODE macro definition.
>       * lib/canonicalize.h: Test GNULIB_CANONICALIZE instead of
>       PROVIDE_CANONICALIZE_FILENAME_MODE.

Hi Bruno,

I'd rather defer this sort of change, since it introduces a hard
dependency on gnulib-tool, with only marginal added value.  With this
sort of change, a project that uses this module without going through
gnulib-tool will not work properly.

If/once we all agree that it's ok to strongly discourage (preferably
via automated checks) the use of gnulib without gnulib-tool, then I'd
have no objection whatsoever to this sort of change.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]