Re: test modules and license

[Bruno Haible]

Simon Josefsson wrote:
> What about the issue of copying code
> between test code and the library?  Then we'd have to talk to the FSF
> every time we want to do that.  This is a minor issue though, it
> hasn't occured in practice yet, as far as I know...

It is rare indeed. And when it occurs, often you have written the test
code yourself that you want to use in the library; in this case you can
just re-contribute to the FSF code that you wrote for the FSF earlier.
According to the papers we sign with the FSF, you are legally entitled
to do this.

I'm applying this:

2007-01-17  Bruno Haible  <address@hidden>

        * gnulib-tool (func_get_license): Revert last patch. Instead, let
        the license default to GPL.
        (func_create_testdir): Don't complain if a module is LGPL and its
        tests module depends on GPLed modules.

*** gnulib-tool 14 Jan 2007 23:00:12 -0000      1.215
--- gnulib-tool 17 Jan 2007 23:33:11 -0000
***************
*** 1020,1029 ****
  # - local_gnulib_dir  from --local-dir
  func_get_license ()
  {
!   # ${module}-tests always implicitly has the same license as ${module}.
!   sed_drop_tests_suffix='s/-tests$//'
!   func_lookup_file "modules/"`echo "$1" | sed -e "$sed_drop_tests_suffix"`
!   sed -n -e "/^License$sed_extract_prog" < "$lookedup_file"
  }
  
  # func_get_maintainer module
--- 1020,1030 ----
  # - local_gnulib_dir  from --local-dir
  func_get_license ()
  {
!   func_lookup_file "modules/$1"
!   { sed -n -e "/^License$sed_extract_prog" < "$lookedup_file"
!     # The default is GPL.
!     echo "GPL"
!   } | sed -e 's,^ *$,,' | sed -e 1q
  }
  
  # func_get_maintainer module
***************
*** 2276,2281 ****
--- 2277,2287 ----
    # Check that the license of every module is consistent with the license of
    # its dependencies.
    saved_modules="$modules"
+   saved_inctests="$inctests"
+   # When computing transitive closures, don't consider $module to depend on
+   # $module-tests. Need this becauses tests are implicitly GPL and may depend
+   # on GPL modules - therefore we don't want a warning in this case.
+   inctests=""
    for requested_module in $saved_modules; do
      requested_license=`func_get_license "$requested_module"`
      if test "$requested_license" != GPL; then
***************
*** 2296,2301 ****
--- 2302,2308 ----
      fi
    done
    modules="$saved_modules"
+   inctests="$saved_inctests"
  
    # Subdirectory names.
    sourcebase=gllib