Re: [bug-gnulib] proposed 'string' module for gnulib

[Bruno Haible]

Hi Paul,

Thanks for the huge work!

Your ChangeLog entry doesn't mark strndup.h, strnlen.h, strpbrk.h, strsep.h,
strstr.h, strtok_r.h as removed. Presumably you want to remove them as well?

In lib/canon-host.c, I'd vote for #including <string.h> before the gnulib
specific headers ("getaddrinfo.h" etc.).

In lib/strstr.c you are betting that <string.h> defines NULL. I wouldn't
bet on that; all I know for sure is that <stddef.h> defines NULL on all
platforms, and also <stdlib.h> defines NULL on all platforms.

In lib/string_.h lines 54, 135, 136, the indentation can be adjusted.

Other than that, it looks all right.

Bruno