bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: enforcing the use of string.h related modules


From: Eric Blake
Subject: Re: enforcing the use of string.h related modules
Date: Thu, 01 Feb 2007 06:40:16 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 2/1/2007 1:03 AM:
> Eric Blake <address@hidden> writes:
> 
>>      * modules/regex (Depends-on): Add mempcpy.
>> ...
>>      * modules/mountlist (Depends-on): Add strstr
> 
> The other parts of your patch might be needed, but these aren't quite
> right.  As far as I can tell, regex does not depend on mempcpy, nor
> does mountlist depend on strstr.  (They may refer to those routines in
> some cases, but they don't depend on those modules.)

Good point.  I'm installing this for regex, but haven't looked at
mountlist yet.

2007-02-01  Eric Blake  <address@hidden>

        * modules/regex (Depends-on): Revert dependence on mempcpy.
        * lib/regex_internal.h [! _LIBC && !__mempcpy]: Undo string
        module's definition of mempcpy.
        Reported by Paul Eggert.

Index: lib/regex_internal.h
===================================================================
RCS file: /sources/gnulib/gnulib/lib/regex_internal.h,v
retrieving revision 1.29
diff -u -p -r1.29 regex_internal.h
- --- lib/regex_internal.h        26 Jan 2007 22:16:55 -0000      1.29
+++ lib/regex_internal.h        1 Feb 2007 13:35:44 -0000
@@ -113,6 +113,7 @@
 # define __iswctype iswctype
 # define __btowc btowc
 # ifndef __mempcpy
+#  undef mempcpy
 #  define __mempcpy mempcpy
 # endif
 # define __wcrtomb wcrtomb
Index: modules/regex
===================================================================
RCS file: /sources/gnulib/gnulib/modules/regex,v
retrieving revision 1.21
diff -u -p -r1.21 regex
- --- modules/regex       1 Feb 2007 05:01:17 -0000       1.21
+++ modules/regex       1 Feb 2007 13:35:44 -0000
@@ -16,7 +16,6 @@ alloca
 extensions
 gettext-h
 malloc
- -mempcpy
 stdint
 strcase
 ssize_t

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFwe2/84KuGfSFAYARAh8WAJ9WGbBfdI2tTb6kdyJHMOw7H//7DgCgrWgr
owuNVp31mVFzqWVbkhMCFrY=
=eYlZ
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]