[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gnulib] enforcing the use of string.h related modules
From: |
Eric Blake |
Subject: |
Re: [bug-gnulib] enforcing the use of string.h related modules |
Date: |
Fri, 02 Feb 2007 06:05:40 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Bruno Haible on 2/1/2007 10:39 AM:
> Eric Blake wrote:
>> Does this look correct to apply?
>
> The MKDIR_P changes are ok but are not yet necessary, as there is only 1
> module that creates the 'arpa' subdirectory and only 1 module that creates
> the 'netinet' subdirectory.
They may not be necessary, but they don't hurt. I value consistency,
particularly in the case of copy-n-paste creation of a new arpa_* module
in the future. So I checked in JUST those two changes.
>
> The Makefile dependency would be highly annoying. Many users don't use the
> automake option 'no-dependencies', therefore use full dependencies.
> A rebuild or modification of a generated header file like string.h or unistd.h
> causes large parts of the package to be rebuilt. The user then sits there
> for minutes and minutes, waiting for gcc to do its job.
Point taken. Patch withdrawn. Which leaves us back in the situation that
if you pick up a gnulib change that alters how string.h would be created,
but that does not affect string_.h, you must either start from 'make
distclean' or remove the offending string.h yourself.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFwzck84KuGfSFAYARAji7AJ4sAhZl86/oMrShNsqPVzImdl9CeACgsjcG
lLXKdzAsc8vSeTx1BZIZQBc=
=mx9e
-----END PGP SIGNATURE-----