[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: more m4 underquotations
From: |
Jim Meyering |
Subject: |
Re: more m4 underquotations |
Date: |
Tue, 13 Feb 2007 23:34:45 +0100 |
Ralf Wildenhues <address@hidden> wrote:
> Hello Bruno, Jim, Paul, all,
>
> I found a couple more underquotations. Here's a proposed quick patch.
> If you prefer some other quoting style (e.g., maximal quoting or
> quadrigraphs, but rather not changequote), I'd be happy to redo.
> OK to apply?
Hi Ralf!
Those look fine to me, though for unlink-busy, I might have
simply changed s/argv\[0\]/*argv/.
Wow. Those are nasty.
I wonder how long they've been there... no doubt far too long.
For example wrt unlink-busy:
$ grep argv0 configure
return !argc || unlink (argv0) != 0;
and that won't even compile, much less run, as the test requires.
And this:
$ grep -i gnu0 configure
*-*-gnu0-9* | \
> Cheers,
> Ralf
>
> 2007-02-13 Ralf Wildenhues <address@hidden>
>
> * m4/intdiv0.m4 (gt_INTDIV0): Fix m4 quoting bug.
> * m4/unlink-busy.m4 (gl_FUNC_UNLINK_BUSY_TEXT): Likewise.
> * m4/unlinkdir.m4 (gl_UNLINKDIR): Likewise.
Please do apply them.