Re: xreadlink

[Jim Meyering]

Bruno Haible <address@hidden> wrote:

> And here's the accompanying coreutils patch. The call in src/readlink.c
> is actually better served with the 1-argument xreadlink(), since memcopying
> a small string is typically faster than a memory allocation of 1 KB.
>
> 2007-02-28  Bruno Haible  <address@hidden>
>
>       * bootstrap.conf (gnulib_modules): Replace xreadlink with
>       xreadlink-with-size. Add xreadlink.
>       * src/copy.c (copy_internal): Update.
>       * src/ls.c (is_directory): Update.
>       * src/stat.c (print_stat): Update.
>       * src/readlink.c (main): Use the one-argument xreadlink function.

Thanks.
That looks fine, so I applied it.
I made this change, too:

        * modules/xreadlink (Maintainer): Add my name.
        * modules/xreadlink-with-size (Depends-on): Alphabetize.

Index: modules/xreadlink
===================================================================
RCS file: /sources/gnulib/gnulib/modules/xreadlink,v
retrieving revision 1.13
diff -u -p -r1.13 xreadlink
--- modules/xreadlink   1 Mar 2007 00:07:34 -0000       1.13
+++ modules/xreadlink   1 Mar 2007 07:34:14 -0000
@@ -22,5 +22,4 @@ License:
 GPL

 Maintainer:
-Bruno Haible
-
+Bruno Haible, Jim Meyering
Index: modules/xreadlink-with-size
===================================================================
RCS file: /sources/gnulib/gnulib/modules/xreadlink-with-size,v
retrieving revision 1.2
diff -u -p -r1.2 xreadlink-with-size
--- modules/xreadlink-with-size 28 Feb 2007 23:53:47 -0000      1.2
+++ modules/xreadlink-with-size 1 Mar 2007 07:34:14 -0000
@@ -6,9 +6,9 @@ lib/xreadlink.h
 lib/xreadlink-with-size.c

 Depends-on:
-xalloc
 readlink
 ssize_t
+xalloc

 configure.ac: