[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
byteswap test failure
From: |
Bruno Haible |
Subject: |
byteswap test failure |
Date: |
Sat, 3 Mar 2007 03:25:04 +0100 |
User-agent: |
KMail/1.5.4 |
Hi Oskar,
A few weeks ago, I contributed a unit test for the 'byteswap' module.
And it fails on MacOS X. bswap_32(0xDEADBEEF) = 0xEFBE00DE. Do you agree
to this proposed patch?
2007-03-02 Bruno Haible <address@hidden>
* lib/byteswap_.h (bswap_32): Fix formula.
--- lib/byteswap_.h 14 May 2005 06:27:58 -0000 1.4
+++ lib/byteswap_.h 3 Mar 2007 02:23:14 -0000
@@ -1,5 +1,5 @@
/* byteswap.h - Byte swapping
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2007 Free Software Foundation, Inc.
Written by Oskar Liljeblad <address@hidden>, 2005.
This program is free software; you can redistribute it and/or modify
@@ -27,7 +27,7 @@
X with reversed byte order. */
#define bswap_32(x) ((((x) & 0x000000FF) << 24) | \
(((x) & 0x0000FF00) << 8) | \
- (((x) & 0x00FF0000) << 8) | \
+ (((x) & 0x00FF0000) >> 8) | \
(((x) & 0xFF000000) >> 24))
/* Given an unsigned 64-bit argument X, return the value corresponding to
- byteswap test failure,
Bruno Haible <=