bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sys_socket module: make <sys/socket.h> self-contained


From: Eric Blake
Subject: Re: sys_socket module: make <sys/socket.h> self-contained
Date: Sat, 03 Mar 2007 07:25:25 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.10) Gecko/20070221 Thunderbird/1.5.0.10 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 3/2/2007 6:33 PM:
> Since our goal is to allow people to program against the POSIX specifications,
> here is a proposed patch. It causes lib/sys/socket.h to be created on
> systems like MacOS X. Tested on Linux, MacOS X, mingw.

OK, except:

> !   if test $gl_cv_header_sys_socket_h_selfcontained = yes; then
>       SYS_SOCKET_H=''
>     else
> +     SYS_SOCKET_H='sys/socket.h'
> + 
>       dnl We cannot use AC_CHECK_HEADERS_ONCE here, because that would make
>       dnl the check for those headers unconditional; yet cygwin reports
>       dnl that the headers are present but cannot be compiled (since on
>       dnl cygwin, all socket information should come from sys/socket.h).

This comment...

> ! 
> !     AC_CHECK_HEADERS([sys/socket.h])
> !     gl_ABSOLUTE_HEADER([sys/socket.h])
> !     ABSOLUTE_SYS_SOCKET_H=\"$gl_cv_absolute_sys_socket_h\"
> !     AC_SUBST([ABSOLUTE_SYS_SOCKET_H])
> !     if test $ac_cv_header_sys_socket_h = yes; then
> !       HAVE_SYS_SOCKET_H=1
> !       HAVE_WINSOCK2_H=0
> !       HAVE_WS2TCPIP_H=0
> !     else
> !       HAVE_SYS_SOCKET_H=0

...should be moved here (and perhaps reworded a bit), to avoid future
copy-n-paste confusion :)

> !       AC_CHECK_HEADERS([winsock2.h ws2tcpip.h])
> !       if test $ac_cv_header_winsock2_h = yes; then

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF6YVU84KuGfSFAYARAummAKC3fk25dZYgiUALfcDQqYInONWuxgCg0nKi
0/hdhXoLJh2BDUzZpHuNekM=
=F/if
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]