bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: netinet_in module: make <netinet.h> self-contained


From: Bruno Haible
Subject: Re: netinet_in module: make <netinet.h> self-contained
Date: Thu, 8 Mar 2007 00:12:56 +0100
User-agent: KMail/1.5.4

Eric Blake wrote:

> >> +     dnl We cannot use AC_CHECK_HEADERS_ONCE here, because that would make
> >> +     dnl the check for those headers unconditional; yet cygwin reports
> >> +     dnl that the headers are present but cannot be compiled (since on
> >> +     dnl cygwin, all socket information should come from netinet/in.h).
> >> + 
> >> +     AC_CHECK_HEADERS([netinet/in.h])
> >
> > _Too much_ copy-n-paste from the sys/socket module.

Simon Josefsson wrote:

> I agree with this objection, but other than that, the general approach
> that Bruno proposed seems like the right thing to me.

OK, I dropped the misplaced comment, and applied the patch.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]