bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: *printf declarations in stdio.h?


From: Bruno Haible
Subject: Re: *printf declarations in stdio.h?
Date: Tue, 27 Mar 2007 13:29:20 +0200
User-agent: KMail/1.5.4

Hi Simon,

> m4/vasprintf.m4 contains:
> ...
>   if test $ac_cv_func_vasprintf = yes; then
>     AC_DEFINE([REPLACE_VASPRINTF], 1,
>       [Define if vasprintf exists but is overridden by gnulib.])
>   fi
> ...
> 
> Which seems OK to me,

No, it is not the right thing. If defines REPLACE_VASPRINTF as a C macro.
But what we need here is to set REPLACE_VASPRINTF as a shell variable
during the configure run.

> however, stdio_.h in my last patch was not OK.
> 
> I believe the version below is better.  It will do the 'rpl_'
> #define's if @REPLACE_VASPRINTF@, but will add prototypes if
> '@REPLACE_VASPRINTF@ || address@hidden@'.

Yes, this is good. Except for the indentation of the lines 190 and 191.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]