Re: new module 'iconv_open'

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> Bruno Haible <bruno <at> clisp.org> writes:
>
>> 
>> Some proprietary iconv() implementations (IRIX, OSF/1, Solaris) are
>> actually usable if
>>   1. one is willing to do an indirect conversion (through UTF-8) if a direct
>>      conversion between two encodings doesn't exist,
>>   2. one maps the standardized encoding names to the implementation specific
>>      ones (not needed on Solaris).
>
> This change breaks compiling the latest git coreutils on at least cygwin:
>
>> 
>> GPERF = gperf
>> iconv_open-aix.h: iconv_open-aix.gperf
>>      $(GPERF) -m 10 iconv_open-aix.gperf > address@hidden
>>      mv address@hidden $@
>
> make[1]: Entering directory `/home/eblake/coreutils/lib'
> gperf -m 10 iconv_open-aix.gperf > iconv_open-aix.h-t
> gperf: invalid option -- m
> Usage: gperf [-cCdDef[num]
> F<initializers>GhH<hashname>i<init>Ijk<keys>K<keyname>lL<language>nN<function 
> name>ors<size>S<switches>tTvW<wordlistname>Z<class name>7] [input-file]
> Try `gperf --help' for more information.
> make[1]: *** [iconv_open-aix.h] Error 1
>
> gperf --version
> GNU gperf 2.7.2
>
> gperf is not on the list of widely available programs, so it must not be 
> invoked by a normal user when compiling a tarball, but requiring maintainers 
> to 
> have gperf available might be reasonable if you could rework this to use a 
> command line that will work with commonly-installed gperf versions.  Which 
> version did you test with?

It works here with gperf 3.0.2.  Well, at least after I installed
gperf, before that I got this error during build:

make[2]: Entering directory `/home/jas/src/libidn/lib/gl'
gperf -m 10 iconv_open-aix.gperf > iconv_open-aix.h-t
/bin/sh: gperf: command not found
make[2]: *** [iconv_open-aix.h] Error 127

No warnings about missing gperf during ./configure.  I think the M4
code should test for a gperf tool, using AM_MISSING_PROG or similar.

/Simon