Re: gnulib tests vs. LDADD

[Bruno Haible]

Eric Blake wrote:
> CVS findutils uses gnulib-tool --with-tests when importing.  But on cygwin, 
> compilation then fails in the gnulib-created directory:
> 
> gcc  -g2 -Wall -Werror   -o test-dirname.exe test-
> dirname.o ../gnulib/lib/libgnulib.a 
> ../gnulib/lib/libgnulib.a(xalloc-die.o): In function `xalloc_die':
> /home/eblake/findutils/gnulib/lib/xalloc-die.c:35: undefined reference to 
> `_libintl_gettext'
> collect2: ld returned 1 exit status
> make[4]: *** [test-dirname.exe] Error 1
> 
> It looks like gnulib needs to take its own advice when creating the 
> Makefile.am 
> for the tests directory, since I noticed the following message from 
> gnulib-tool:

Yes indeed. I'm committing this as an attempt to fix it.

2007-04-03  Bruno Haible  <address@hidden>

        * modules/argmatch-tests (Makefile.am): New variable
        test_argmatch_LDADD.
        * modules/argp-tests (Makefile.am): New variable test_argp_LDADD.
        * modules/array-list-tests (Makefile.am): New variable
        test_array_list_LDADD.
        * modules/array-oset-tests (Makefile.am): New variable
        test_array_oset_LDADD.
        * modules/avltree-list-tests (Makefile.am): New variable
        test_avltree_list_LDADD.
        * modules/avltree-oset-tests (Makefile.am): New variable
        test_avltree_oset_LDADD.
        * modules/avltreehash-list-tests (Makefile.am): New variable
        test_avltreehash_list_LDADD.
        * modules/canonicalize-lgpl-tests (Makefile.am): New variable
        test_canonicalize_lgpl_LDADD.
        * modules/carray-list-tests (Makefile.am): New variable
        test_carray_list_LDADD.
        * modules/dirname-tests (Makefile.am): New variable
        test_dirname_LDADD.
        * modules/linked-list-tests (Makefile.am): New variable
        test_linked_list_LDADD.
        * modules/linkedhash-list-tests (Makefile.am): New variable
        test_linkedhash_list_LDADD.
        * modules/rbtree-list-tests (Makefile.am): New variable
        test_rbtree_list_LDADD.
        * modules/rbtree-oset-tests (Makefile.am): New variable
        test_rbtree_oset_LDADD.
        * modules/rbtreehash-list-tests (Makefile.am): New variable
        test_rbtreehash_list_LDADD.
        * modules/xvasprintf-tests (Makefile.am): New variable
        test_xvasprintf_LDADD.
        Reported by Eric Blake.

--- modules/argmatch-tests      4 Mar 2007 13:39:32 -0000       1.1
+++ modules/argmatch-tests      4 Apr 2007 00:42:12 -0000
@@ -9,4 +9,5 @@
 Makefile.am:
 TESTS += test-argmatch
 check_PROGRAMS += test-argmatch
+test_argmatch_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/argp-tests  3 Mar 2007 00:34:56 -0000       1.4
+++ modules/argp-tests  4 Apr 2007 00:42:12 -0000
@@ -8,4 +8,5 @@
 Makefile.am:
 TESTS += test-argp test-argp-2.sh
 check_PROGRAMS += test-argp 
+test_argp_LDADD = @LIBINTL@ $(LDADD)
 EXTRA_DIST += test-argp-2.sh
--- modules/array-list-tests    3 Mar 2007 01:43:55 -0000       1.2
+++ modules/array-list-tests    4 Apr 2007 00:42:12 -0000
@@ -9,4 +9,5 @@
 Makefile.am:
 TESTS += test-array_list
 check_PROGRAMS += test-array_list
+test_array_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/array-oset-tests    3 Mar 2007 01:47:40 -0000       1.2
+++ modules/array-oset-tests    4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-array_oset
 check_PROGRAMS += test-array_oset
+test_array_oset_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/avltree-list-tests  3 Mar 2007 01:50:21 -0000       1.3
+++ modules/avltree-list-tests  4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-avltree_list
 check_PROGRAMS += test-avltree_list
+test_avltree_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/avltree-oset-tests  3 Mar 2007 01:52:12 -0000       1.3
+++ modules/avltree-oset-tests  4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-avltree_oset
 check_PROGRAMS += test-avltree_oset
+test_avltree_oset_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/avltreehash-list-tests      3 Mar 2007 01:54:22 -0000       1.3
+++ modules/avltreehash-list-tests      4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-avltreehash_list
 check_PROGRAMS += test-avltreehash_list
+test_avltreehash_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/canonicalize-lgpl-tests     11 Mar 2007 00:55:27 -0000      1.1
+++ modules/canonicalize-lgpl-tests     4 Apr 2007 00:42:12 -0000
@@ -10,5 +10,6 @@
 TESTS += test-canonicalize-lgpl.sh
 TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@'
 check_PROGRAMS += test-canonicalize-lgpl
+test_canonicalize_lgpl_LDADD = @LIBINTL@ $(LDADD)
 EXTRA_DIST += test-canonicalize-lgpl.sh
 
--- modules/carray-list-tests   3 Mar 2007 04:01:15 -0000       1.3
+++ modules/carray-list-tests   4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-carray_list
 check_PROGRAMS += test-carray_list
+test_carray_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/dirname-tests       10 Mar 2007 14:56:09 -0000      1.2
+++ modules/dirname-tests       4 Apr 2007 00:42:12 -0000
@@ -9,3 +9,4 @@
 Makefile.am:
 TESTS += test-dirname
 noinst_PROGRAMS += test-dirname
+test_dirname_LDADD = @LIBINTL@ $(LDADD)
--- modules/linked-list-tests   3 Mar 2007 12:42:29 -0000       1.3
+++ modules/linked-list-tests   4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-linked_list
 check_PROGRAMS += test-linked_list
+test_linked_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/linkedhash-list-tests       3 Mar 2007 04:05:36 -0000       1.3
+++ modules/linkedhash-list-tests       4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-linkedhash_list
 check_PROGRAMS += test-linkedhash_list
+test_linkedhash_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/rbtree-list-tests   3 Mar 2007 12:56:10 -0000       1.3
+++ modules/rbtree-list-tests   4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-rbtree_list
 check_PROGRAMS += test-rbtree_list
+test_rbtree_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/rbtree-oset-tests   3 Mar 2007 12:58:43 -0000       1.3
+++ modules/rbtree-oset-tests   4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-rbtree_oset
 check_PROGRAMS += test-rbtree_oset
+test_rbtree_oset_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/rbtreehash-list-tests       3 Mar 2007 13:00:31 -0000       1.3
+++ modules/rbtreehash-list-tests       4 Apr 2007 00:42:12 -0000
@@ -10,4 +10,5 @@
 Makefile.am:
 TESTS += test-rbtreehash_list
 check_PROGRAMS += test-rbtreehash_list
+test_rbtreehash_list_LDADD = @LIBINTL@ $(LDADD)
 
--- modules/xvasprintf-tests    4 Mar 2007 18:05:48 -0000       1.1
+++ modules/xvasprintf-tests    4 Apr 2007 00:42:12 -0000
@@ -9,4 +9,5 @@
 Makefile.am:
 TESTS += test-xvasprintf
 check_PROGRAMS += test-xvasprintf
+test_xvasprintf_LDADD = @LIBINTL@ $(LDADD)