bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: autobuild.m4


From: Bruno Haible
Subject: Re: autobuild.m4
Date: Fri, 13 Apr 2007 00:33:08 +0200
User-agent: KMail/1.5.4

Hi Simon,

> Any objections to this patch?

Only minor ones:

- About the naming of the naming of the module. It's confusing to see
  indications that "autobuild" is
    - A package downloadable from your site that makes it easy to collect
      the results of automatic builds,
    - A web site (autobuild.josefsson.org) that presents the results of
      automatic builds,
    - A gnulib module that provides identification for a particular build,
    - A shell script generated by gnulib that prepares some build logs
      from automatic builds. [This one is from me. My bad.]
  A piece of documentation in doc/ could improve the understanding, but
  more importantly, I think the names of these 4 things should be succint
  and expressive. There is nothing more confusing than 1 term designating
  two or more different but related concept.

  Can you come up with 4 different names for these?

- Indenting by a tab and then by 3 spaces is unusual.

- The double-quotes here surprise me:
      if test "$?" != 0
  I thought $? always expands to a non-empty sequence of digits. Are
  you expecting a negative integer as value of "$?" ?

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]