bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: isnanf syntax error


From: Bruno Haible
Subject: Re: isnanf syntax error
Date: Wed, 30 May 2007 00:57:12 +0200
User-agent: KMail/1.5.4

Eric Blake wrote:
> checking whether isnan(float) works... guessing yes
> ../configure: line 14918: test: too many arguments
> 
> 2007-05-29  Eric Blake  <address@hidden>
> 
>       * m4/isnanf.m4 (gl_FUNC_ISNANF_NO_LIBM): Avoid syntax error on
>       cross compiles.
> 
> Index: m4/isnanf.m4
> ===================================================================
> RCS file: /sources/gnulib/gnulib/m4/isnanf.m4,v
> retrieving revision 1.3
> diff -u -p -r1.3 isnanf.m4
> --- m4/isnanf.m4      20 May 2007 00:25:31 -0000      1.3
> +++ m4/isnanf.m4      29 May 2007 12:48:50 -0000
> @@ -1,4 +1,4 @@
> -# isnanf.m4 serial 2
> +# isnanf.m4 serial 3
>  dnl Copyright (C) 2007 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -13,7 +13,7 @@ AC_DEFUN([gl_FUNC_ISNANF_NO_LIBM],
>      gl_ISNANF_WORKS
>    fi
>    if test $gl_cv_func_isnanf_no_libm = yes \
> -     && test $gl_cv_func_isnanf_works = yes; then
> +     && test "$gl_cv_func_isnanf_works" = yes; then
>      AC_DEFINE([HAVE_ISNANF_IN_LIBC], 1,
>        [Define if the isnan(float) function is available in libc.])
>    else

Thanks. But this is still not right: When gl_cv_func_isnanf_works has
the value "guessing yes", as in this case, we want to treat it like "yes",
not like "no". I'm applying this additional patch:

*** m4/isnanf.m4        29 May 2007 12:50:20 -0000      1.4
--- m4/isnanf.m4        29 May 2007 22:50:33 -0000
***************
*** 13,19 ****
      gl_ISNANF_WORKS
    fi
    if test $gl_cv_func_isnanf_no_libm = yes \
!      && test "$gl_cv_func_isnanf_works" = yes; then
      AC_DEFINE([HAVE_ISNANF_IN_LIBC], 1,
        [Define if the isnan(float) function is available in libc.])
    else
--- 13,23 ----
      gl_ISNANF_WORKS
    fi
    if test $gl_cv_func_isnanf_no_libm = yes \
!      && { case "$gl_cv_func_isnanf_works" in
!             *yes) true;;
!             *) false;;
!           esac
!         }; then
      AC_DEFINE([HAVE_ISNANF_IN_LIBC], 1,
        [Define if the isnan(float) function is available in libc.])
    else





reply via email to

[Prev in Thread] Current Thread [Next in Thread]