[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lseek always include windows.h?

From: Simon Josefsson
Subject: Re: lseek always include windows.h?
Date: Tue, 05 Jun 2007 17:58:53 +0200
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.0.95 (gnu/linux)

Eric Blake <address@hidden> writes:

> That looks correct to me - only windows platforms should be failing this 
> test, 
> as it is written.  Can you show the config.log snippet that explains why 
> uClinux claimed to fail the test?

I see you already fixed this, thanks!

>> Generally, it seems lseek gets pulled in by getpass, via fseeko.  I
>> wonder if getpass need to use fseeko?
> Yes, because of the GNU philosophy of avoiding arbitrary limits (including a 
>>2gb file that getpass happens to be reading from).

I didn't follow the discussions regarding fseek*, but will using 'fseek
(out, 0, SEEK_CUR);' instead of fseek really break anything?

Btw, the error value from fseeko is not checked.  Would it make sense to
avoid printing \n if fseeko failed?  Printing the \n when fseeko may
lead to revealing the password, if I understand the comment correctly
(and if the comment is in fact correct).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]