[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bootstrap fixes
From: |
Paul Eggert |
Subject: |
Re: bootstrap fixes |
Date: |
Tue, 19 Jun 2007 13:41:24 -0700 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
"Sergey Poznyakoff" <address@hidden> writes:
> case $file in
> */INSTALL) dst=INSTALL;;
> - *) dst=$file;;
> + *) dst=$build_aux/`expr $file : 'build-aux/\(.*\)'`;;
> esac
> symlink_to_gnulib $file $dst || exit
I'd feel a bit better if expr was called only for file names beginning
with build-aux/ and if expr quoted its file argument. Something like
this:
case $file in
*/INSTALL) dst=INSTALL;;
build-aux/*) dst=$build_aux/`expr "$file" : 'build-aux/\(.*\)'`;;
*) dst=$file;;
esac
Other than that, it looks fine to me; please install. And thanks.
- bootstrap fixes, Sergey Poznyakoff, 2007/06/19
- Re: bootstrap fixes,
Paul Eggert <=