Re: gnulib-tool nits

[Ralf Wildenhues]

Hello Bruno, all,

* Ralf Wildenhues wrote on Sat, Jun 23, 2007 at 03:18:49PM CEST:
> 
>       * gnulib-tool: Fix iteration over $PATH by IFS by adding `:' at
>       the end.  Fix indentation.
>       (func_create_megatestdir): Likewise.
>       Report by Bruno Haible.

This still needs to be addressed.  For now I've applied the indentation
fix only, as below, as that seemed to be noncontroversial.

FWIW, I tend to agree with Paul's suggestion made here:
<http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/10632/focus=10658>

Thanks,
Ralf

2007-07-01  Ralf Wildenhues  <address@hidden>

        * gnulib-tool: Fix indentation.
        (func_create_megatestdir): Likewise.
        Report by Bruno Haible.

Index: gnulib-tool
===================================================================
RCS file: /cvsroot/gnulib/gnulib/gnulib-tool,v
retrieving revision 1.241
diff -u -r1.241 gnulib-tool
--- gnulib-tool 23 Jun 2007 19:21:30 -0000      1.241
+++ gnulib-tool 1 Jul 2007 07:51:48 -0000
@@ -887,23 +887,22 @@
   /*) self_abspathname="$0" ;;
   */*) self_abspathname=`pwd`/"$0" ;;
   *)
-  
-  self_abspathname=
-  save_IFS=$IFS
-  IFS=:
-  for d in $PATH; do
+    self_abspathname=
+    save_IFS=$IFS
+    IFS=:
+    for d in $PATH; do
+      IFS=$save_IFS
+      test -z "$d" && d=.
+      if test -x "$d/$0" && test ! -d "$d/$0"; then
+       self_abspathname=$d/$0
+       break
+      fi
+    done
     IFS=$save_IFS
-    test -z "$d" && d=.
-    if test -x "$d/$0" && test ! -d "$d/$0"; then
-      self_abspathname=$d/$0
-      break
+    if test -z "$self_abspathname"; then
+      func_fatal_error "could not locate the gnulib-tool program - how did you 
invoke it?"
     fi
-  done
-  IFS=$save_IFS
-  if test -z "$self_abspathname"; then
-    func_fatal_error "could not locate the gnulib-tool program - how did you 
invoke it?"
-  fi
-  ;;
+    ;;
 esac
 while test -h "$self_abspathname"; do
   # Resolve symbolic link.
@@ -3058,7 +3057,7 @@
                    -e 's,October,10,'   -e 's,Oct,10,' \
                    -e 's,November,11,'  -e 's,Nov,11,' \
                    -e 's,December,12,'  -e 's,Dec,12,' \
-                   -e 's,^,00,'         -e 's,^[0-9]*\([0-9][0-9] \),\1,' \
+                   -e 's,^,00,' -e 's,^[0-9]*\([0-9][0-9] \),\1,' \
                    -e 's,^\([0-9]*\) \([0-9]*\) \([0-9]*\),\3\2\1,'`
   (echo '#!/bin/sh'
    echo "CVSDATE=$cvsdate"