[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: yesno module consumes too much input

From: Eric Blake-1
Subject: Re: yesno module consumes too much input
Date: Fri, 17 Aug 2007 13:23:08 -0700 (PDT)

> The yesno module has a problem on platforms where exit()
> does not implicitly flush seekable input streams

The yesno module also has a potential POSIX-compliance problem
on all platforms.  Inside rpmatch, the code uses _("^[yY]") to
get the locale-specific regex to use as the yesexpr.  However,
this is not necessarily the same as using nl_langinfo(YESEXPR).
Likewise for NOEXPR.

Either gettext should special-case the strings "^[yY]" and "^[nN]",
or rpmatch should be fixed to use nl_langinfo instead of gettext.

If nothing else, we should add a TRANSLATOR comment before
both regex strings in rpmatch.c, to make it obvious that these strings
should be consistent with the locale's choice of yesexpr and noexpr,
rather than the usual use of _() to designate translated output.

Eric Blake

View this message in context: 
Sent from the Gnulib mailing list archive at Nabble.com.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]