bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU tar 1.19 doesn't build on Solaris 8 due to strerror problem


From: Eric Blake-1
Subject: Re: GNU tar 1.19 doesn't build on Solaris 8 due to strerror problem
Date: Thu, 11 Oct 2007 15:12:54 -0700 (PDT)

> GNU tar 1.19 doesn't build on Solaris 8, because strerror.c uses
> CHAR_BIT without defining it.  The problem occurs on any hosts that
> has strerror but where strerror(-2) doesn't return a useful string.

I'm committing this followup:

From: Eric Blake <address@hidden>
Date: Thu, 11 Oct 2007 16:10:24 -0600
Subject: [PATCH] Don't claim strerror is broken on Interix.

* doc/functions/strerror.texi (strerror): Known broken systems are
now Solaris 8, and not Interix.
* m4/strerror.m4 (gl_FUNC_STRERROR_SEPARATE): No longer filter out
Interix on cross-compile.
Reported by Martin Koeppe in
http://lists.gnu.org/archive/html/bug-gnulib/2007-10/msg00005.html.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog                   |   10 ++++++++++
 doc/functions/strerror.texi |    2 +-
 m4/strerror.m4              |    9 +++------
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7684335..71748aa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2007-10-11  Eric Blake  <address@hidden>
+
+       Don't claim strerror is broken on Interix.
+       * doc/functions/strerror.texi (strerror): Known broken systems are
+       now Solaris 8, and not Interix.
+       * m4/strerror.m4 (gl_FUNC_STRERROR_SEPARATE): No longer filter out
+       Interix on cross-compile.
+       Reported by Martin Koeppe in
+       http://lists.gnu.org/archive/html/bug-gnulib/2007-10/msg00005.html.
+
 2007-10-11  Bruno Haible  <address@hidden>
 
        * modules/i-ring-tests: New file.
diff --git a/doc/functions/strerror.texi b/doc/functions/strerror.texi
index aad3754..012b691 100644
--- a/doc/functions/strerror.texi
+++ b/doc/functions/strerror.texi
@@ -14,7 +14,7 @@ This function is missing on some old platforms.
 @item
 This function fails to return a string for out-of-range integers on
 some platforms:
-Interix
+Solaris 8
 @end itemize
 
 Portability problems not fixed by Gnulib:
diff --git a/m4/strerror.m4 b/m4/strerror.m4
index f59c710..9cb5769 100644
--- a/m4/strerror.m4
+++ b/m4/strerror.m4
@@ -1,4 +1,4 @@
-# strerror.m4 serial 5
+# strerror.m4 serial 6
 dnl Copyright (C) 2002, 2007 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -26,13 +26,10 @@ AC_DEFUN([gl_FUNC_STRERROR_SEPARATE],
         [return !*strerror (-2);])],
       [gl_cv_func_working_strerror=yes],
       [gl_cv_func_working_strerror=no],
-      [dnl Assume crossbuild works if it compiles, except for Interix.
+      [dnl Assume crossbuild works if it compiles.
        AC_COMPILE_IFELSE(
-         [AC_LANG_PROGRAM(
+        [AC_LANG_PROGRAM(
            [#include <string.h>
-            #ifdef __INTERIX
-              Interix is broken;
-            #endif
            ],
            [return !*strerror (-2);])],
         [gl_cv_func_working_strerror=yes],
-- 
1.5.3.2


-- 
View this message in context: 
http://www.nabble.com/GNU-tar-1.19-doesn%27t-build-on-Solaris-8-due-to-strerror-problem-tf4610189.html#a13165809
Sent from the Gnulib mailing list archive at Nabble.com.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]