bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sync maintainer-makefile files


From: Simon Josefsson
Subject: Re: Sync maintainer-makefile files
Date: Mon, 22 Oct 2007 20:20:14 +0200
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux)

Micah Cowan <address@hidden> writes:

>> The second set of patches is against gnulib to remove most of the rules
>> in coreutils, to avoid duplication.  This removes some features from
>> gnulib's maint.mk, but has anyone been using them heavily?  If so, we
>> can add them again by making small incremental patches against coreutils
>> and gnulib.
>> 
>> Thoughts?
>
> Didn't you just remove the vast majority of targets from maint.mk?
> There's barely anything left at all! Why bother having a maint.mk in the
> first place then?

It isn't completely empty, and more importantly, it serves as a place
holder for things to move from coreutils.

> I have only just begun using it, but I find all of the following useful:
>
>> -sc_cast_of_argument_to_free:
>> -sc_cast_of_x_alloc_return_value:
>> -sc_cast_of_alloca_return_value:
>> -sc_space_tab:
>
> ^^  *especially* that one...
>
>> -sc_changelog:
>> -syntax-check: $(syntax-check-rules)
>
> Throwing out several useful rules, which AFAICT make up almost the
> entirety of maint.mk, just because coreutils already has them, is a bad
> move, IMO.

Once we have made coreutils use the gnulib module for these files, would
you be interested in working on merging back the rules from coreutils to
gnulib?  You could propose patches for both coreutils and gnulib.  Many
of the rules will need to be thought through because coreutils have
several assumptions that doesn't hold in gnulib.

/Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]