bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new module: xprintf


From: Bruno Haible
Subject: Re: new module: xprintf
Date: Mon, 22 Oct 2007 23:05:25 +0200
User-agent: KMail/1.5.4

Eric Blake wrote:
> > Any objection to making this module also provide xvprintf and xvfprintf?  
> > M4 
> > has a use of vfprintf, which would be nice to have the wrapper for.
> 
> As in the following?  (Also, it fixes a C89 compiler issue).

Fine with me. Just nitpicking:

  - I would call the local variable 'retval', not 'err', since it contains
    more information than just whether an error occurred. It tells how many
    bytes of output were produced.

  - In the comment, "without setting the error indicator" can be misunderstood,
    because the main error indicator is always 'errno'. I would say
    "without setting the stream's error indicator" or
    "for a reason not related to the stream".

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]