[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: OpenBSD frexpl failure
From: |
Eric Blake |
Subject: |
Re: OpenBSD frexpl failure |
Date: |
Fri, 07 Dec 2007 06:31:04 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 12/5/2007 9:08 PM:
>>> It looks like float.in.h needs to be updated to cater for another platform
>>> with a broken <float.h>.
>> Can you try it out (change float_h.m4, float.in.h, and then run a testdir
>> with
>> tests from frexpl, isnanl, ldexpl, floorl, ceill, roundl, truncl etc.)?
>> I have no access to an OpenBSD machine.
>
> With this quick patch (no ChangeLog, yet), all 12 tests pass
I'm wondering if we should also add a configure-time compile test in
float_h.m4, which does the sanity check of this untested snippet:
AC_CHECK_SIZEOF([double])
AC_CHECK_SIZEOF([long double])
AC_COMPUTE_INT([variable],
[(SIZEOF_DOUBLE == SIZEOF_LONG_DOUBLE)
== (DBL_MANT_DIG == LDBL_MANT_DIG)], [<float.h>])
Then we could make float.in.h always be replaced if the sanity check
fails, and additionally make it robust enough to #error out (or
equivalent) for platforms where we have not ported the correct
characteristics, rather than the current scenario of silently doing
nothing about the bad <float.h>.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHWUsY84KuGfSFAYARAtHPAKCRl8WBwz7h/+eYs9/YwNtr+UN+WwCgk8Tt
mRqwfPbkcIo6AIr47szw0LI=
=nzm+
-----END PGP SIGNATURE-----