bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support versions of autoconf prior to 2.59c.


From: Ralf Wildenhues
Subject: Re: Support versions of autoconf prior to 2.59c.
Date: Mon, 10 Dec 2007 19:41:06 +0100
User-agent: Mutt/1.5.17 (2007-11-13)

Hello Jim,

* Jim Meyering wrote on Mon, Dec 10, 2007 at 02:38:41PM CET:
> >
> >     Support versions of autoconf prior to 2.59c.
> >     * gnulib-tool (func_emit_initmacro_done): Define m4_foreach_w
> >     if it is not already defined.
> 
> Hi Bruno,
> I've just rebased, after pulling your latest changes.
> 
> Any objection?

I'm not Bruno, but from looking at it, the patch seems fine and mostly
sufficient to me.  I say mostly, because Autoconf 2.59 will not turn on
C99 nor GNU extensions, which in turn will expose on GNU/Linux the glob.c 
  for (size_t i; ...)
couple of issues that I reported a couple of months ago (but then with old
Solaris cc).

Cheers,
Ralf

> ---
>  gnulib-tool |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/gnulib-tool b/gnulib-tool
> index 35638b9..69a53df 100755
> --- a/gnulib-tool
> +++ b/gnulib-tool
> @@ -2014,6 +2014,13 @@ func_emit_initmacro_done ()
>    echo "  AS_LITERAL_IF([\$1], [${macro_prefix_arg}_LIBSOURCES([\$1.c])])dnl"
>    echo "  ${macro_prefix_arg}_LIBOBJS=\"\$${macro_prefix_arg}_LIBOBJS 
> \$1.\$ac_objext\""
>    echo "])"
> +
> +  echo "# m4_foreach_w is provided by autoconf-2.59c and later."
> +  echo "# This definition is to accommodate developers using versions"
> +  echo "# of autoconf older than that."
> +  echo "m4_ifndef([m4_foreach_w],"
> +  echo "  [m4_define([m4_foreach_w],"
> +  echo "    [m4_foreach([\$1], m4_split(m4_normalize([\$2]), [ ]), 
> [\$3])])])"
>    echo
>    echo "# Like AC_REPLACE_FUNCS, except that the module name goes"
>    echo "# into ${macro_prefix_arg}_LIBOBJS instead of into LIBOBJS."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]