bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: memmem speedup


From: Eric Blake
Subject: Re: memmem speedup
Date: Mon, 07 Jan 2008 19:53:46 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 1/7/2008 5:54 PM:
|
| Thanks for the comments; they are essential for understanding the code.
| I also find your comments clearer than the text in .../~lecroq/...

Thanks for your review.  Also, is there any reason to have the c_strstr
module?  Its implementation looks like it is identical to the POSIX
requirements for strstr (POSIX states that strstr always operates on byte
sequences, whether or not they form valid character strings for the
current locale).  Your comments about when it is safe to use c_strstr
rather than mbsstr, even in the presence of multibyte sequence locales, is
useful, but as far as I could see, those comments apply equally to strstr.


- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHguW684KuGfSFAYARAuq8AKDD1vKYaIz5UYohhXmAix2I7UFZKACcDVo7
Sepx6Y3O6LU7OfW1aXIgqQQ=
=jty7
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]