Re: strstr speedup

[Bruno Haible]

Eric Blake wrote:
> Are there still broken platforms out there where tolower() disobeys
> the POSIX requirement that it leave the argument unchanged if it was not
> already an upper-case letter?

This portability problem is very old. I don't think it's still relevant,
but I don't know for sure.

> so we can directly use tolower() here without expanding the
> argument multiple times?

I would not put side effects into the argument of tolower(): Some platforms
may expand it into a macro which evaluates the argument more than once.

Bruno