Re: sockets

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Simon Josefsson on 1/18/2008 7:45 AM:
| One thing worries me though; cygwin.  I don't know if this is needed on
| cygwin.  I would expect the answer is no?  The m4 check should fail on
| cygwin, but I'm not sure it does right now.

You are correct - the module is not needed on cygwin (cygwin apps should
neither link against -lws2_32, nor call WSA*, when using POSIX socket
functions).  The m4 file is correct:

checking whether <sys/socket.h> is self-contained... yes
checking if we need to call WSAStartup in winsock2.h and -lws2_32... no

However, the test file is incorrect:

gcc  -g -O2   -o test-sockets.exe test-sockets.o ../gllib/libgnu.a
test-sockets.o: In function `main':
/home/eblake/gnulib/testdir2736/build/gltests/../../gltests/test-sockets.c:29:
undefined reference to `_gl_sockets_startup'
/home/eblake/gnulib/testdir2736/build/gltests/../../gltests/test-sockets.c:36:
undefined reference to `_gl_sockets_cleanup'
collect2: ld returned 1 exit status

Were you intending that all apps using sockets call
gl_sockets_{start,clean}up (in which case, you need to declare them,
perhaps as a no-op define, for non-mingw platforms), or were you intending
these functions to be called under the hood when using a socket-based API
in compliance with POSIX (in which case, your test should not call them
directly, but call a function that uses them under the hood)?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHkf++84KuGfSFAYARAtmYAJ4w3KWV8W7B+0zM8BD8P/M+pAhSAACfaVR0
Y7bWqE0qTKQHaiiO/XdEGBk=
=XaWO
-----END PGP SIGNATURE-----