bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI, new sha256 and sha512 modules in coreutils


From: Simon Josefsson
Subject: Re: FYI, new sha256 and sha512 modules in coreutils
Date: Mon, 03 Mar 2008 08:24:43 +0100
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux)

Jim Meyering <address@hidden> writes:

> FYI, I've just created the sha256 and sha512 modules and
> moved the remaining sha*-related files from coreutils/{lib,m4}
> into coreutils/gl/{lib,m4}.
>
>     http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=f33599c1441

Looks fine.  Would you consider adding define's for the digest size in
the *.h files?  Something like:

#define SHA256_DIGEST_SIZE 32

#define SHA384_DIGEST_SIZE 48

#define SHA512_DIGEST_SIZE 64

The define's are useful when declaring local variables statically to
hold the output digest.

The u64.h file looks quite useful, we do something similar but ad-hoc in
gnutls, so I would welcome adding it to gnulib.

/Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]