Re: FYI, new sha256 and sha512 modules in coreutils

[Jim Meyering]

Simon Josefsson <address@hidden> wrote:
...
>> Sure.  Please send a patch.
>> SHA224, too, I suppose?
>> I have a preference for using enum symbols, if that works for you.
>>
>> enum { SHA512_DIGEST_SIZE = 64 };
>
> Sure.  See below.  I was unsure whether to put both declarations in the
> same enum or not.  I'm not sure what the preferred style is.

That looks fine.  Thanks.

FYI, I applied it and manually changed the Author/Email fields.
If you were to send patches in "git format-patch" format,
then I could apply-and-give-credit much more efficiently,
with a simple "git am FILE".

Note how I also added a one-line summary.  That one-line summary is
important: not only does it become the Subject in "git format-patch"
output, but it can also serve to identify the patch in git commands.
E.g., from now on, "git log ':/Define SHA*_DIGEST'..HEAD" will print
log entries for all changes in coreutils since this one of yours.

Once I've committed your change, here's the command I use to generate
the patch:

  git format-patch --stdout HEAD~1

>From dcc543f44c56d1b5793e4fcc1f3ef9bfb5e4ee54 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Mon, 3 Mar 2008 08:52:42 +0100
Subject: [PATCH] Define SHA*_DIGEST_SIZE symbols.

* gl/lib/sha256.h (SHA224_DIGEST_SIZE, SHA256_DIGEST_SIZE): Define.
* gl/lib/sha512.h (SHA384_DIGEST_SIZE, SHA512_DIGEST_SIZE): Define.

---
 gl/lib/sha256.h |    2 ++
 gl/lib/sha512.h |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/gl/lib/sha256.h b/gl/lib/sha256.h
index 9fd83c9..c35d6c1 100644
--- a/gl/lib/sha256.h
+++ b/gl/lib/sha256.h
@@ -31,6 +31,8 @@ struct sha256_ctx
   uint32_t buffer[32];
 };

+enum { SHA224_DIGEST_SIZE = 24 };
+enum { SHA256_DIGEST_SIZE = 32 };

 /* Initialize structure containing state of computation. */
 extern void sha256_init_ctx (struct sha256_ctx *ctx);
diff --git a/gl/lib/sha512.h b/gl/lib/sha512.h
index 7ee3ac4..84fe559 100644
--- a/gl/lib/sha512.h
+++ b/gl/lib/sha512.h
@@ -32,6 +32,8 @@ struct sha512_ctx
   u64 buffer[32];
 };

+enum { SHA384_DIGEST_SIZE = 48 };
+enum { SHA512_DIGEST_SIZE = 64 };

 /* Initialize structure containing state of computation. */
 extern void sha512_init_ctx (struct sha512_ctx *ctx);
--
1.5.4.3.366.g9f9b62