Re: gnulib-tool --version

[Bruno Haible]

Jim Meyering wrote:
> > |   Also, the suffix "-dirty" is a bit offensive. How about "-unreleased" or
> > |   "-dev", or "-alpha" or "-cuttingedge", or "-mm" (for Linux fans :-)?
> >
> > That's something for Jim to decide, with the git-version-gen script.  But
> > given those options, I like '-dev'.  At any rate, the '-dirty' suffix is
> > only present if you have uncommitted changes still in your tree.
> 
> I agree that "-dirty" is a little annoying, but think of that as a feature ;-)
> It might encourage people not to use a version labeled "-dirty".

On the contrary, the free software community strives by the fact that
everyone can use modified copies. We would be nowhere if everyone would use
only unmodified copies of, say, RedHat distributions.

> Besides, it's shorter than "-modified".  "-dev" sounds too much like
> it could be something legitimate or reproducible, like a version from
> a public development branch.

I agree that "-dev" reminds a public development branch. But "-modified"
captures well the situation.

It's not too long, since "gnulib-tool --version" still has 13 characters of
room on the first line.

I therefore applied this:


2008-03-23  Bruno Haible  <address@hidden>

        Tweak "gnulib --version" output.
        * gnulib-tool (func_version): Replace "-dirty" suffix with "-modified".

*** gnulib-tool.orig    2008-03-23 12:28:00.000000000 +0100
--- gnulib-tool 2008-03-23 12:26:50.000000000 +0100
***************
*** 209,215 ****
      date=`echo "$date" | sed -e "$sed_year_before_time"`
      # Use GNU date to compute the time in GMT.
      date=`date -d "$date" -u +"%Y-%m-%d %H:%M:%S"`
!     version=' '`"$gnulib_dir"/build-aux/git-version-gen /dev/null`
    else
      if test -d "$gnulib_dir"/CVS \
         && (cvs --version) >/dev/null 2>/dev/null; then
--- 209,215 ----
      date=`echo "$date" | sed -e "$sed_year_before_time"`
      # Use GNU date to compute the time in GMT.
      date=`date -d "$date" -u +"%Y-%m-%d %H:%M:%S"`
!     version=' '`"$gnulib_dir"/build-aux/git-version-gen /dev/null | sed -e 
's/-dirty/-modified/'`
    else
      if test -d "$gnulib_dir"/CVS \
         && (cvs --version) >/dev/null 2>/dev/null; then