Re: lock.h missing stub for gl_lock_destroy in single-threaded case

[Bruno Haible]

Hello,

Bruce Merry wrote:
> In lib/lock.h, there is stub code to allow compilation event when no
> threading is supported, but it is missing the various destroy functions.
> 
> Patch is attached following the existing conventions.

Thank you. Applied with this ChangeLog entry:

2008-04-17  Bruno Haible  <address@hidden>

        * lib/lock.h (gl_lock_destroy, gl_rwlock_destroy,
        gl_recursive_lock_destroy): Provide no-op definitions for the dummy
        implementation.
        Patch by Bruce Merry <address@hidden>.


> I think, though,that at least some of the stubs ought to expand to
> "((void) 0)" rather than nothing.

Yes, in theory you are right... But since this dummy fallback case is not
used normally, it doesn't make much of a difference. Those who care about gcc
warnings mostly develop on systems with POSIX threads.

Bruno