bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fpurge.c error when building m4 1.4.11


From: Bruno Haible
Subject: Re: fpurge.c error when building m4 1.4.11
Date: Mon, 21 Apr 2008 23:43:59 +0200
User-agent: KMail/1.5.4

Eric Blake wrote:
> Unless you're claiming that the compiler might warn about the
> explicit shift by 32 bits on platforms where my patch below now
> compiles the shift (in a dead code branch) where it was
> previously omitted by the #if, but that's okay with me

Yes, that's what I meant. And it's OK with me as well.

> * lib/memchr2.c (memchr2): Avoid embedded #if.

Thanks!

> (should we also change memchr.c to match, since I borrowed from there in
> writing memchr2.c)?

That's not needed, IMO: That code uses ULONG_MAX which usually carries only
a single L, not the suffix LL.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]