Re: acl: make acl_entries work reliably

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> Hi Jim,
>
> In my tests, I found that the textual representation of ACLs varies much
> more than the API used to access the ACLs.
>
> The acl_entries() function, currently, converts the ACL to a string whose
> format is undocumented and then starts counting newlines. This is already
> known to go wrong on IRIX.
>
> Here's an implementation that is more reliable: it uses the documented
> acl_get_entry() API. Except on two platforms:
>   - On IRIX, acl_get_entry is undocumented.
>   - On Tru64, acl_get_entry takes only 1 argument, not 3, and in my tests
>     always returned NULL.
> But on these platforms, the innards of the ACL are exposed through 
> <sys/acl.h>.
>
> OK?
>
>
> 2008-06-02  Bruno Haible  <address@hidden>
>
>       * lib/acl_entries.c (acl_entries): Rewrite to use acl_get_entry.
>       * lib/copy-acl.c (qcopy_acl): Update comment.

Impeccable work and obvious improvements.
Go right ahead.  Thanks!