[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: acl: finish support for MacOS X
|
From: |
Jim Meyering |
|
Subject: |
Re: acl: finish support for MacOS X |
|
Date: |
Sun, 08 Jun 2008 12:11:41 +0200 |
Bruno Haible <address@hidden> wrote:
> On MacOS X the testsuite still fails:
...
> Please review (although I commit it immediately, because more patches are
> coming.)
...
> + if (ret != 0)
> + {
> + int saved_errno = errno;
> +
> + if (ACL_NOT_WELL_SUPPORTED (errno) && !(acl_entries (acl) > 0))
> + {
Why use the negation? I prefer this:
if (ACL_NOT_WELL_SUPPORTED (errno) && acl_entries (acl) <= 0)
Otherwise, it all looks fine.