bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lock warnings on mingw


From: Eric Blake
Subject: Re: lock warnings on mingw
Date: Tue, 17 Jun 2008 19:19:41 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 6/17/2008 6:36 PM:
| I vote against it. If you cast away the 'volatile', the compiler is allowed
| to cache some intermediate values in registers, effectively turning the
| supposedly atomic operation into a non-atomic one. I find it better to live
| with the warnings rather than to introduce a bug in our code that would stay
| a bug even after mingw's bug is fixed.

Which means that compilation with '-Wall -Werror' will fail for
multithreaded apps on mingw until they fix their bug - oh well; using
- -Werror has always been a risky proposition.  But based on your other
patches to set the default choice for thread API, this particular bug
won't be tickled in a default single-thread compile.

Also, I noticed that 'gnulib-tool --test' favors the single-threaded API;
does this mean we are lacking on coverage of threading code in gnulib?

|
|> [1] http://msdn.microsoft.com/en-us/library/ms683614(VS.85).aspx
|>
|> ../../lib/lock.c: In function `glthread_lock_lock':
|> ../../lib/lock.c:550: warning: passing arg 1 of `InterlockedIncrement'
discards qualifiers from pointer target type
|
| You have diagnosed it as a mingw header bug; please report it to the mingw
| maintainers if you have time.

Done:
https://sourceforge.net/tracker/index.php?func=detail&aid=1996620&group_id=2435&atid=102435

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAkhYYq0ACgkQ84KuGfSFAYAt8gCUC3CLAy25gE0DvksGlZJPVfL/
VACdF7aSwmkAaGuVpnepjGa3wvIis9s=
=uEBf
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]