bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFE] function to read a file descriptor


From: Ralf Wildenhues
Subject: Re: [RFE] function to read a file descriptor
Date: Tue, 19 Aug 2008 22:18:33 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Debarshi,

* Debarshi Ray wrote on Tue, Aug 19, 2008 at 05:29:28AM CEST:
> >      *buffer = realloc (*buffer, *size);
> 
> Oops, I meant to use xrealloc there.

FWIW, your current algorithm of adding BUFSIZ to size causes nonlinear
amount of work done in realloc, for reading large files.  You might
want to increase memory by a constant factor or BUFSIZ, whichever is
larger (e.g., just like read-file does), and thus less often than you
recv.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]