Re: [PATCH]: poll module issue on Win32

[Paolo Bonzini]

> I included the module, although the code need to be updated to include
> <fcntl.h> in order to compile.

Thanks.

> I think a few simple case would not be particularly hard to write:
> - non connected socket
> - socket data detection

I will try to do something like that.

> That would help a lot in testing and reporting problem for your new
> Win32 module. I'm testing under wine, and the condition really are
> suboptimal.

Indeed, thanks for doing it.  I could try installing wine too.

> BTW your current module disable select() emulation on WIN32 platform,
> which prevent me from compiling the application I'm using for testing -
> so an unit test would really be welcome.

What do you mean by "disable select() emulation on WIN32 platform?"  The
socket enhancements disable select, but it shouldn't affect an
application that uses poll.  If you get compilation errors in an
application, please report them.

Paolo