bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] testsuite for poll(2)


From: Yoann Vandoorselaere
Subject: Re: [PATCH] testsuite for poll(2)
Date: Fri, 12 Sep 2008 16:01:58 +0200

Le vendredi 12 septembre 2008 à 15:49 +0200, Paolo Bonzini a écrit :
> > - enum { TRUE, FALSE } will fail to compile on WIN32, better use
> > stdbool, or :
> 
> See patch at end of message.
> 
> > - The code need to be linked to -lws2_32 to avoid undefined symbols, yet
> > the dependency is not pulled automatically.
> 
> Also fixed in the patch by using the sockets module.  If you report good
> things about it, I'll commit it.
> 
> > i586-mingw32msvc-gcc  -g -O2   -o test-poll.exe
> > test-poll.o ../gllib/libgnu.a -lws2_32
> > test-poll.o: In function `test_pipe':
> > /home/yoann/dev/prelude/git/gnulib/poll/gltests/test-poll.c:347:
> > undefined reference to `_pipe'
> 
> Also fixed in the patch (there should really be a unistd.h replacement
> in gnulib...).
> 
> > test-poll.o: In function `open_server_socket':
> > /home/yoann/dev/prelude/git/gnulib/poll/gltests/test-poll.c:91:
> > undefined reference to `_inet_aton'
> > test-poll.o: In function `connect_to_socket':
> > /home/yoann/dev/prelude/git/gnulib/poll/gltests/test-poll.c:121:
> > undefined reference to `_inet_aton'
> 
> These should be provided by ws2_32.

This patch introduce a new issue:

test-poll.c: In function ‘connect_to_socket’:
test-poll.c:127: warning: passing argument 3 of ‘win_ioctl’ from
incompatible pointer type
test-poll.c: In function ‘test_pipe’:
test-poll.c:346: error: too few arguments to function ‘_pipe’


> > ../gllib/libgnu.a(poll.o): In function `rpl_poll':
> > /home/yoann/dev/prelude/git/gnulib/poll/gllib/poll.c:154: undefined
> > reference to `_select_not_supported_under_win32_use_poll'
> 
> I suppose this is with the winsock patch, but without the poll patch?
> The two go together -- either both, or none.

I'm using both your poll and winsock patch.

-- 
Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies
Tel: +33 (0)8 70 70 21 58                  Fax: +33(0)4 78 42 21 58
http://www.prelude-ids.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]