Re: [PATCH] implement full-blown select(2) for winsock

[Paolo Bonzini]

> I don't think this code should be built just because someone wanted the
> sys/socket.h header and added the sys_socket module.  There are many
> places you want the sys/socket.h header without calling select.

Ok, I'll place it into sys_select instead.

> Compare other header files and system
> functions for how to do it, e.g., stdio.in.h and fopen: the replacement
> for fopen isn't pulled in by the stdio-h module normally, but the
> stdio.in.h code helps the fopen module when in use.
> 
> Possibly this argument applies to the winsock.c code as well, but I
> haven't looked into it.

The difference is that without these fixes, winsock is simply just too
crippled for the casual Unix programmer.  Providing sys/socket.h and
sys/select.h without anything like these wrappers was just giving a
false sense of portability.

Paolo