Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

[Bruno Haible]

Yoann Vandoorselaere wrote on 2008-09-18:
> Here is a new version of the patches, contain more dependencies fixes,

Yup, I noticed these as well:
  - 'errno' is needed as a dependency because of ETIMEDOUT,
  - 'time' is needed as a dependency for 'struct timespec'.

Also, let me make the definitions of gl_cond_define and gl_cond_initializer
more copy&paste-friendly.


2008-09-30  Yoann Vandoorselaere  <address@hidden>
            Bruno Haible  <address@hidden>

        * modules/cond (Dependencies): Add errno, time.
        * lib/glthread/cond.h: Include <time.h>.
        (gl_cond_define, gl_cond_define_initialized): Use the same definition
        across platforms.

--- lib/glthread/cond.h.orig    2008-10-01 03:10:38.000000000 +0200
+++ lib/glthread/cond.h 2008-10-01 02:59:49.000000000 +0200
@@ -52,6 +52,7 @@
 #include <errno.h>
 #include <stdbool.h>
 #include <stdlib.h>
+#include <time.h>
 
 #include "glthread/lock.h"
 
@@ -122,9 +123,9 @@
 
 typedef pthread_cond_t gl_cond_t;
 # define gl_cond_define(STORAGECLASS, NAME) \
-    STORAGECLASS pthread_cond_t NAME;
+    STORAGECLASS gl_cond_t NAME;
 # define gl_cond_define_initialized(STORAGECLASS, NAME) \
-    STORAGECLASS pthread_cond_t NAME = gl_cond_initializer;
+    STORAGECLASS gl_cond_t NAME = gl_cond_initializer;
 # define gl_cond_initializer \
     PTHREAD_COND_INITIALIZER
 # define glthread_cond_init(COND) \
@@ -181,9 +182,9 @@
 
 typedef pth_cond_t gl_cond_t;
 # define gl_cond_define(STORAGECLASS, NAME) \
-    STORAGECLASS pth_cond_t NAME;
+    STORAGECLASS gl_cond_t NAME;
 # define gl_cond_define_initialized(STORAGECLASS, NAME) \
-    STORAGECLASS pth_cond_t NAME = gl_cond_initializer;
+    STORAGECLASS gl_cond_t NAME = gl_cond_initializer;
 # define gl_cond_initializer \
     PTH_COND_INIT
 # define glthread_cond_init(COND) \
@@ -239,11 +240,11 @@
 
 /* -------------------------- gl_cond_t datatype -------------------------- */
 
-typedef pthread_cond_t gl_cond_t;
+typedef cond_t gl_cond_t;
 # define gl_cond_define(STORAGECLASS, NAME) \
-    STORAGECLASS cond_t NAME;
+    STORAGECLASS gl_cond_t NAME;
 # define gl_cond_define_initialized(STORAGECLASS, NAME) \
-    STORAGECLASS cond_t NAME = gl_cond_initializer;
+    STORAGECLASS gl_cond_t NAME = gl_cond_initializer;
 # define gl_cond_initializer \
     DEFAULTCV
 # define glthread_cond_init(COND) \
--- modules/cond.orig   2008-10-01 03:10:38.000000000 +0200
+++ modules/cond        2008-10-01 02:59:49.000000000 +0200
@@ -9,7 +9,9 @@
 Depends-on:
 threadlib
 lock
+errno
 stdbool
+time
 
 configure.ac:
 gl_COND