[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: filevercmp: please post final filevercmp
|
From: |
Kamil Dudka |
|
Subject: |
Re: filevercmp: please post final filevercmp |
|
Date: |
Fri, 3 Oct 2008 13:04:49 +0000 |
|
User-agent: |
KMail/1.9.7 |
On Friday 03 of October 2008 09:55:40 Jim Meyering wrote:
> Please review these small changes that I expect to fold into your change
> set: - use c_isdigit, c_isalpha, c_isalnum directly; no need for casts -
Sorry, but I am not sure here. This was Bruno's suggestion from
http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00115.html but we
moved from ctype.h to c-ctype.h since that. The c-ctype module is new to me.
I am not in office right now to probe it...
> reword match_suffix comment
> - reword module description
> - s/0/NULL/ in test-filevercmp.c
No problem here...
Kamil