bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: filevercmp: please post final filevercmp


From: Jim Meyering
Subject: Re: filevercmp: please post final filevercmp
Date: Fri, 03 Oct 2008 13:21:31 +0200

Kamil Dudka <address@hidden> wrote:

> On Friday 03 of October 2008 09:55:40 Jim Meyering wrote:
>> Please review these small changes that I expect to fold into your change
>> set: - use c_isdigit, c_isalpha, c_isalnum directly; no need for casts -
> Sorry, but I am not sure here. This was Bruno's suggestion from
> http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00115.html but we
> moved from ctype.h to c-ctype.h since that. The c-ctype module is new to me.
> I am not in office right now to probe it...

Oops.  You're right.
While some of the uses are ok without the cast (i.e., in order),
others do required it.  So I'll leave the casts.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]