bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use gnulib modules close (new) and open to hook into open/cl


From: Simon Josefsson
Subject: Re: [PATCH] use gnulib modules close (new) and open to hook into open/close
Date: Thu, 09 Oct 2008 08:25:07 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Bruno Haible <address@hidden> writes:

>> The Winsock replacement of close is triggered by the socket and accept
>> modules.
>
> I prefer and propose to not trigger the 'close' module from 'socket' or
> 'accept', and instead - just like for select - rely on the link error or
> the warning of someone tries to use close() with sockets enabled
> (recall: a link error when compiling on mingw, a warning when compiling
> with GNULIB_POSIXCHECK on Linux).

+1

> Ok?

I looked over the code, and think the general approach is good.  I'll
test it once it is pushed.

Thanks,
Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]