[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use gnulib modules close (new) and open to hook into open/cl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] use gnulib modules close (new) and open to hook into open/close |
|
Date: |
Sat, 11 Oct 2008 14:21:05 +0200 |
|
User-agent: |
Thunderbird 2.0.0.17 (Macintosh/20080914) |
Bruno Haible wrote:
>> AC_DEFUN([gl_FUNC_CLOSE],
>> [
>> ! m4_ifdef([gl_PREREQ_SYS_H_WINSOCK2], [
>> ! gl_PREREQ_SYS_H_WINSOCK2
>> ! if test $UNISTD_H_HAVE_WINSOCK2_H = 1; then
>> ! gl_REPLACE_CLOSE
>> ! fi
>> ! ])
>> ])
>
> I'm not so happy with this code. If we create a tests directory where
> the 'close' module is part of lib/ and 'sys_socket' is part of tests/,
> the code in lib/ will be compiled in a way that does not invoke the
> _gl_close_fd_maybe_socket function in tests/.
So that would mean that there would be problems if anything that
requires sys_socket in the tests would not require it in the library module.
Considering that the only test module requiring sys_socket right now is
poll-tests, and it is actually just for clarity because poll requires
sys_socket too (via sys_select), I think we can live with it.
Paolo
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, (continued)
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/08
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Simon Josefsson, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Paolo Bonzini, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/11
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close,
Paolo Bonzini <=
- Re: [PATCH] use gnulib modules close (new) and open to hook into open/close, Bruno Haible, 2008/10/09