Re: gcc v4.3.2 problem with strtol.c

[Monty Taylor]

Monty Taylor wrote:
> Hey all... Compiling with this:
> 
> 
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..
> -DDEFAULT_TEXT_DOMAIN=\"drizzle-gnulib\" -W -Wall -Wextra
> -Wunused-macros -pedantic -Wundef -Wstrict-prototypes
> -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
> -Wno-strict-aliasing -Werror -O3 -ggdb3 -DUNIV_LINUX -MT strtol.lo -MD
> -MP -MF .deps/strtol.Tpo -c strtol.c  -fPIC -DPIC -o .libs/strtol.o
> 
> Gives me:
> 
> cc1: warnings being treated as errors
> strtol.c:240: error: no previous prototype for ‘__strtol_internal’
> strtol.c: In function ‘__strtol_internal’:
> strtol.c:241: error: unused parameter ‘group’
> strtol.c:223:1: error: macro "WEAKNAME" is not used
> make[3]: *** [strtol.lo] Error 1
> 
> 
> The WEAKNAME is easy - it's not used in strtol.c and can be removed.
> 
> The __strtol_internal seems a little harder, since this seems to be
> trying to override something specific. Perhaps there needs to be another
> m4 check for something?

Adding #include <inttypes.h> to strtol.c seems to have fixed the
problem. (with the exception of WEAKNAME... which removing fixed)