Re: [PATCH] ignore-value: new module

[Jim Meyering]

Bruno Haible <address@hidden> wrote:

> Hi Jim,
>
>> +Depends-on:
>> +inline
>> +
>> +configure.ac:
>> +
>
> The 'inline' module is overkill here, since you don't use the HAVE_INLINE
> macro. In other words, you don't really care whether the function gets
> inlined or not. In this situation, a simple AC_C_INLINE invocation would be
> sufficient:
>
>   Depends-on:
>
>   configure.ac:
>   AC_REQUIRE([AC_C_INLINE])

Thanks.
I've done that:

>From 916dbd2380c32ea05e01ee9328fdce73197fd691 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 17 Oct 2008 13:43:21 +0200
Subject: [PATCH] ignore-value: don't depend on inline module

* modules/ignore-value (Depends-on): Remove 'inline'.
(configure.ac): Instead, add AC_REQUIRE([AC_C_INLINE]) here.
Suggestion from Bruno Haible.
---
 ChangeLog            |    7 +++++++
 modules/ignore-value |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c54aa17..d85acea 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-10-17  Jim Meyering  <address@hidden>
+
+       ignore-value: don't depend on inline module
+       * modules/ignore-value (Depends-on): Remove 'inline'.
+       (configure.ac): Instead, add AC_REQUIRE([AC_C_INLINE]) here.
+       Suggestion from Bruno Haible.
+
 2008-10-17  Bruno Haible  <address@hidden>

        New implementation of condition variables for Win32.
diff --git a/modules/ignore-value b/modules/ignore-value
index 32991ab..5b32fd1 100644
--- a/modules/ignore-value
+++ b/modules/ignore-value
@@ -5,9 +5,9 @@ Files:
 lib/ignore-value.h

 Depends-on:
-inline

 configure.ac:
+AC_REQUIRE([AC_C_INLINE])

 Makefile.am:
 lib_SOURCES += ignore-value.h
--
1.6.0.2.532.g84ed4c