bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

compiler warning: thread on mingw


From: Eric Blake
Subject: compiler warning: thread on mingw
Date: Wed, 22 Oct 2008 05:56:13 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

../../tests/glthread/thread.c: In function `gl_thread_exit_func':
../../tests/glthread/thread.c:213: warning: control reaches end of
non-void function

I'm committing this:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj/FN0ACgkQ84KuGfSFAYBzXwCgywA6Kzs357E5WX7u0lF6Fsxr
sOYAn0I96hpw2I40CtcdK45c6Bo22qcQ
=2CEq
-----END PGP SIGNATURE-----
>From 82815032e8d476c22edde5e36f70c25038638aab Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Wed, 22 Oct 2008 05:47:28 -0600
Subject: [PATCH] glthread/thread: avoid compiler warning

* lib/glthread/thread.c (gl_thread_exit_func) [USE_WIN32_THREADS]:
Add unreachable abort to silence compiler.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog             |    6 ++++++
 lib/glthread/thread.c |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 46ecb98..0dca26b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2008-10-22  Eric Blake  <address@hidden>
 
+       glthread/thread: avoid compiler warning
+       * lib/glthread/thread.c (gl_thread_exit_func) [USE_WIN32_THREADS]:
+       Add unreachable abort to silence compiler.
+
+2008-10-22  Eric Blake  <address@hidden>
+
        netdb: also supply struct addrinfo for cygwin 1.5.x
        * m4/netdb_h.m4 (gl_HEADER_NETDB): Check for incomplete header on
        older cygwin.
diff --git a/lib/glthread/thread.c b/lib/glthread/thread.c
index 4ebfc54..fa8aede 100644
--- a/lib/glthread/thread.c
+++ b/lib/glthread/thread.c
@@ -210,6 +210,7 @@ gl_thread_exit_func (void *retval)
   gl_thread_t thread = gl_thread_self ();
   thread->result = retval;
   _endthreadex (0); /* calls ExitThread (0) */
+  abort ();
 }
 
 #endif
-- 
1.6.0.2


reply via email to

[Prev in Thread] Current Thread [Next in Thread]