bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warning: module to simplify adding compiler warnings


From: Simon Josefsson
Subject: Re: warning: module to simplify adding compiler warnings
Date: Mon, 10 Nov 2008 20:30:45 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

>> so how about something like this module?
>
> I'm indifferent, except that a better werror framework in Autoconf could
> make your approach obsolete.

Let me know when it is released. :)

>> +  AC_COMPILE_IFELSE(AC_LANG_PROGRAM([]), foo=yes, foo=no)
>
> This looks M4-underquoted; also, 'foo' seems such an arbitrary name.
> How about gl_warning_works?

Right.

> Please note that the next GCC release will handle -Wno* switches that it
> does not know about differently than older ones: it will not error out
> about them; it will warn about them, but *only* if there is at least one
> other warning in the output.

Darn.  The code still works relatively well, though, doesn't it?  It
won't detect non-supported parameters as easily, but non-supported
ignored parameters doesn't hurt.

> Also, how come you do not cache your test results?  (You'd need a cache
> variable that contains the warning name, AS_TR_SH-translated).

Indeed.

>> +License:
>> +LGPLv2+
>
> If the module contains nothing but Autoconf macro code, it is IMVHO more
> useful to just be free about it, no?  Don't all of gnulib m4 macros use
> the license exception Autoconf uses?

The m4 license is normally not mentioned in the modules file.  I'll use
'unlimited' instead, although I'm not sure what that refers to.

I'll post updated proposal in separate e-mails after I have tested it
some more.

/Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]